Fix version topic publish #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-salminen
approved these changes
Mar 4, 2024
| @@ -329,11 +330,16 @@ int board_determine_hw_info(void) | |||
|
|
|||
| /* Make local copies of guid and hwinfo */ | |||
|
|
|||
| memcpy(&guid, device_serial_number, min(sizeof(device_serial_number), sizeof(guid))); | |||
| memcpy(&hwinfo, hw_info, min(sizeof(hwinfo), sizeof(hw_info))); | |||
| memcpy(guid.mfguid, device_serial_number, min(sizeof(device_serial_number), sizeof(guid))); | |||
There was a problem hiding this comment.
Should sizeof(guid) be sizeof(guid.mfguid) ?
Same for hwinfo below ?
…n topics. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_version_topic_publis
branch
from
6770743 to
7b2170f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data was not copied in the correct place inside the topic structure