Enable pre-merge HW boot tests

[vjuntunen]

Enable HW boot test to pre-merge pipeline

[henrirosten]

@vjuntunen: Please reference test results if you have tested this.

[henrirosten]

On line 12, I think you want to set this to true:

def purge_stashed_artifacts = false

Otherwise, we would keep all the images ever build on all PR pushes, which would explode the storage use.

[vjuntunen]

Oh yes I enabled that purge. And maybe we wait for next pre-merge run and take that as reference if succeeded.

[henrirosten]

@vjuntunen: I think you are testing this in prod, right?

I see your changes add an 'Artifacts' link on pre-merge builds, but the link is now broken because you purge them.

[vjuntunen]

Yes in prod, because we do not have that static system to test that in dev. Should that purge delete that link also? I just use it here.. But now boot tests are all green for pre-merge line: https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/job/ghaf-pre-merge-pipeline/319/

[vjuntunen]

https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/job/ghaf-pre-merge-pipeline/321/console here is green pre-merge line without artifact link.

[henrirosten]

LGTM.

For any upcoming changes, please find a way to test this in dev or your private deployment.