Add commit hash parameter #117
Conversation
|
@azbeleva: Have you tested this? Can you add a link to the test run if you did? |
utils.groovy
Outdated
| @@ -205,6 +205,7 @@ def ghaf_hw_test(String flakeref, String device_config, String testset='_boot_') | |||
| def imgdir = find_img_relpath(flakeref, 'archive') | |||
| def remote_path = "artifacts/${env.ARTIFACTS_REMOTE_PATH}" | |||
| def img_url = "${env.JENKINS_URL}/${remote_path}/${imgdir}" | |||
| def commit_hash = (img_url =~ /commit_([a-f0-9]{40})/)[0][1] | |||
There was a problem hiding this comment.
So the line 208 would change to something like:
def commit_hash = "${env.TARGET_COMMIT}"
azbeleva
force-pushed
the
add_commit_hash
branch
6 times, most recently
from
5822b67 to
4b6b21d
Compare
azbeleva
force-pushed
the
add_commit_hash
branch
2 times, most recently
from
c04346b to
60ded58
Compare
Signed-off-by: Mariia Azbeleva <[email protected]>
azbeleva
force-pushed
the
add_commit_hash
branch
from
60ded58 to
dbafe5b
Compare
| @@ -44,11 +44,13 @@ def ghaf_robot_test(String testname='boot') { | |||
| try { | |||
| // Pass variables as environment variables to shell. | |||
| // Ref: https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#string-interpolation | |||
| env.COMMIT_HASH = "${params.COMMIT_HASH}" | |||
There was a problem hiding this comment.
What if params.COMMIT_HASH is missing?
You might want to add a check for such case:
if(!params.containsKey('COMMIT_HASH')) {
println "Missing COMMIT_HASH parameter"
# Can we continue exexution if COMMIT_HASH is not set?
# If not, you probably want to fail the build here, e.g.:
sh "exit 1"
}There was a problem hiding this comment.
we can continue if it is missing, but can it actually be missing if it is provided in utils.groovy ( string(name: "COMMIT_HASH", value: "$commit_hash") )? it can be empty maybe or the error will happen somewhere else?
There was a problem hiding this comment.
It's possible ghaf-hw-test pipeline would be triggered from somewhere else too, not only from that one function in utils.groovy. Although, currently that's not the case.
You decide if you want to add such check or not. I'm fine either way.
No description provided.