Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up RSpec-based test suite and seed with tests #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@mojavelinux
Copy link
Contributor Author

In order for GitHub Actions to run, I think you need to enable it on the repository. If it already is, then I think this PR has to be merged in order for it to initiate the workflow. You can find the result of the workflow in my fork: https://github.com/mojavelinux/open-uri-cached/actions/runs/1629945306

@tigris
Copy link
Owner

tigris commented Dec 28, 2021

Thanks for this. I've written a few of my own in the meantime as well.

Will see if I can incorporate them all.

@tigris
Copy link
Owner

tigris commented Dec 28, 2021

Apologies. I attempted to fix merge conflicts, but seems we were doing similar things in slightly different ways 🤣 .

I've pushed out 1.0.0 for now which should work on ruby 3.1.x and we can merge these tests later. Thanks for your efforts today!

@mojavelinux
Copy link
Contributor Author

I just submitted the tests as an idea to get you started. Feel free to modify them as you see fit. If you need anything else from me, don't hesitate to ask. I'm glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants