Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated implictly nullable parameter #792

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fix deprecated implictly nullable parameter #792

merged 3 commits into from
Nov 28, 2024

Conversation

datlechin
Copy link
Contributor

Fix Deprecate implicitly nullable parameter types, see https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

@bakerkretzmar bakerkretzmar self-assigned this Nov 24, 2024
@bakerkretzmar bakerkretzmar changed the title Add PHP8.4 support Fix deprecated implictly nullable parameter Nov 25, 2024
@bakerkretzmar
Copy link
Collaborator

Can you remove the array|string|null type declaration you added in this PR? I don't believe that's actually an issue for the deprecation thing because that parameter isn't typed at all, and adding those types would be a backwards compatibility break (even if they're accurate).

datlechin
datlechin commented Nov 28, 2024
View reviewed changes
src/Ziggy.php Outdated Show resolved Hide resolved
@bakerkretzmar bakerkretzmar merged commit ca40646 into tighten:2.x Nov 28, 2024
22 checks passed
@bakerkretzmar
Copy link
Collaborator

Thanks.

@bakerkretzmar bakerkretzmar mentioned this pull request Nov 28, 2024
Closed
@datlechin datlechin deleted the php8.4-support branch November 29, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bakerkretzmar bakerkretzmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datlechin @bakerkretzmar