Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix nova-stripe styles overriding base #49

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

faxblaster
Copy link
Contributor

Since our stylesheet is being loading on Nova boot, our tailwind classes were overriding Nova's base tailwind classes (which sometimes vary from ours), causing layout issues outside Nova Stripe.

To prevent this, this bugfix prefixes our tailwind classes and updates our components to use them where necessary.

Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@faxblaster faxblaster merged commit 4f420d6 into main Aug 17, 2022
@faxblaster faxblaster deleted the alk/fix-styles branch August 17, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants