Merge pull request #344 from tighten/v9.52.5-changes

v9.52.5 changes

src/Collect/Support/Str.php

@@ -735,7 +735,7 @@ public static function random($length = 16)
             while (($len = strlen($string)) < $length) {
                 $size = $length - $len;
 
-                $bytesSize = (int) ceil(($size) / 3) * 3;
+                $bytesSize = (int) ceil($size / 3) * 3;
 
                 $bytes = random_bytes($bytesSize);
 

tests/Support/SupportArrTest.php

@@ -731,6 +731,12 @@ public function testRandom()
         $this->assertCount(2, array_intersect_assoc(['one' => 'foo', 'two' => 'bar', 'three' => 'baz'], $random));
     }
 
+    public function testRandomNotIncrementingKeys()
+    {
+        $random = Arr::random(['foo' => 'foo', 'bar' => 'bar', 'baz' => 'baz']);
+        $this->assertContains($random, ['foo', 'bar', 'baz']);
+    }
+
     public function testRandomOnEmptyArray()
     {
         $random = Arr::random([], 0);
@@ -817,6 +823,11 @@ public function testShuffleWithSeed()
         );
     }
 
+    public function testEmptyShuffle()
+    {
+        $this->assertEquals([], Arr::shuffle([]));
+    }
+
     public function testSort()
     {
         $unsorted = [

tests/Support/SupportCollectionTest.php

@@ -4682,6 +4682,7 @@ public function testCollectionFromTraversableWithKeys($collection)
 
     /**
      * @dataProvider collectionClassProvider
+     *
      * @requires PHP >= 8.1
      */
     public function testCollectionFromEnum($collection)
@@ -4692,6 +4693,7 @@ public function testCollectionFromEnum($collection)
 
     /**
      * @dataProvider collectionClassProvider
+     *
      * @requires PHP >= 8.1
      */
     public function testCollectionFromBackedEnum($collection)

tests/files/Support/Str.php

@@ -735,7 +735,7 @@ public static function random($length = 16)
             while (($len = strlen($string)) < $length) {
                 $size = $length - $len;
 
-                $bytesSize = (int) ceil(($size) / 3) * 3;
+                $bytesSize = (int) ceil($size / 3) * 3;
 
                 $bytes = random_bytes($bytesSize);
 

upgrade.sh

@@ -382,7 +382,7 @@ function getCurrentVersionFromGitHub()
     echo Getting current version from $repository...
 
     if [ -z "$requestedVersion" ]; then
-        collectionVersion=$(git ls-remote $repository --tags  v9.52\* | grep tags/ | grep -v {} | cut -d \/ -f 3 | cut -d v -f 2  | grep -v RC | grep -vi beta | sort -t. -k 1,1n -k 2,2n -k 3,3n| tail -1)
+        collectionVersion=$(git ls-remote $repository --tags  v9.5\* | grep tags/ | grep -v {} | cut -d \/ -f 3 | cut -d v -f 2  | grep -v RC | grep -vi beta | sort -t. -k 1,1n -k 2,2n -k 3,3n| tail -1)
     else
         collectionVersion=$requestedVersion
     fi