Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 0.16.17 TigerBeetle #38

Merged
merged 13 commits into from
Dec 18, 2024
Merged

Upgrade to 0.16.17 TigerBeetle #38

merged 13 commits into from
Dec 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Upgrade to new 0.16.17 version of TigerBeetle.

@github-actions github-actions bot added enhancement New feature or request k::dependencies Pull requests that update a dependency file k::version Version bump zig Related to Zig code labels Dec 15, 2024
@tyranron tyranron self-assigned this Dec 15, 2024
@tyranron tyranron marked this pull request as draft December 15, 2024 09:14
@tyranron tyranron added this to the next milestone Dec 15, 2024
@tyranron
Copy link
Member

tyranron commented Dec 16, 2024 •
edited
Loading

@zetanumbers since there are some API changes (see added CHANGELOG), it would be nice to have your feedback on this, if you'd find some time for this. Otherwise, I'll merge it in 2-3 working days.

@tyranron tyranron requested a review from zetanumbers December 16, 2024 19:04
@tyranron tyranron marked this pull request as ready for review December 16, 2024 19:04
zetanumbers
zetanumbers approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@zetanumbers zetanumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment about #[non_exhaustive] LGTM

core/src/callback.rs Show resolved Hide resolved
core/src/callback.rs Show resolved Hide resolved
@tyranron
Copy link
Member

@zetanumbers thanks!

@tyranron tyranron merged commit fc3de47 into master Dec 18, 2024
17 checks passed
@tyranron tyranron deleted the upgrade-to-0.16.17 branch December 18, 2024 23:27
tyranron added a commit that referenced this pull request Dec 30, 2024
@tyranron
Remove unnecessary improper_ctypes lint suppression (#38)
f3ea694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron left review comments

@zetanumbers zetanumbers zetanumbers approved these changes

Assignees

@tyranron tyranron

Labels
enhancement New feature or request k::dependencies Pull requests that update a dependency file k::version Version bump zig Related to Zig code
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tyranron @zetanumbers