Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Client API ergonomics #34

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Improve Client API ergonomics #34

merged 1 commit into from
Nov 27, 2024

Conversation

50U10FCA7
Copy link
Contributor

Allow to specify OperationKind (without converting it to packet::Operation manually) in Client::packet.

@50U10FCA7 50U10FCA7 mentioned this pull request Nov 25, 2024
Merged
@50U10FCA7
Copy link
Contributor Author

FCM

Improve `Client::packet` ergonomics (#34)

zetanumbers
zetanumbers approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@zetanumbers zetanumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyranron tyranron added enhancement New feature or request k::api Related to API (application interface) labels Nov 27, 2024
@tyranron tyranron added this to the 0.5.0 milestone Nov 27, 2024
@tyranron tyranron merged commit dc064d4 into tigerbeetle-rust:master Nov 27, 2024
@50U10FCA7 50U10FCA7 deleted the improve-ergonomics branch November 27, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetanumbers zetanumbers zetanumbers approved these changes

Assignees

@50U10FCA7 50U10FCA7

Labels
enhancement New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@50U10FCA7 @zetanumbers @tyranron