Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1547-Upgrade-failing #796

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bmckercher123
Copy link
Contributor

@bmckercher123 bmckercher123 commented Jul 6, 2023

Ticket from community member: #716.

Product Version(s):
OSS 3.25, 3.26

Issue:
https://tigera.atlassian.net/browse/DOCS-1547

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@bmckercher123 bmckercher123 requested a review from lwr20 July 6, 2023 22:07
@bmckercher123 bmckercher123 requested a review from a team as a code owner July 6, 2023 22:07
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview succeeded!

Name Link
🔨 Latest commit 0ce8f47
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/64ca90b422ea1e00082effa0
😎 Deploy Preview https://deploy-preview-796--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bmckercher123 bmckercher123 force-pushed the DOCS-1547-Upgrade-failing branch from f972161 to 75f25e8 Compare July 6, 2023 22:15
```
kubectl replace -f <manifest-file-name>
```bash
kubectl apply --server-side --force-conflicts -f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this line and many others the manifest file is no longer present.

Copy link
Contributor Author

@bmckercher123 bmckercher123 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what your comment means. Are you saying the command should be and leave the reference to manifest?:

kubectl apply -- --force-conflicts -f

Copy link
Member

@rene-dekker rene-dekker Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be kubectl apply --server-side --force-conflicts -f <manifest-file-name>

@@ -129,16 +129,15 @@ the output and then re-running the command without --dry-run to commit to the ch

:::

1. Use the following command to initiate a rolling update, after replacing
`<manifest-file-name>` with the file name of your {{version}} manifest.
1. Use the following command to initiate a rolling update.
Copy link
Member

@rene-dekker rene-dekker Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be nicer if the curl step before this step would would store the manifest as a fixed name, like upgrade.yaml
so that you can modify all commands below to apply upgrade.yaml:

kubectl apply --server-side --force-conflicts -f upgrade.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in stead of

curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico.yaml -O
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/canal.yaml -O
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico-policy-only.yaml -O

it would be:

curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico.yaml -o upgrade.yaml
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/canal.yaml -o upgrade.yaml
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico-policy-only.yaml -o upgrade.yaml

Copy link
Contributor Author

@bmckercher123 bmckercher123 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene-dekker We can do above, but the manifests paths using {{version}} are failing in netlify (see logs). Unless you or Dan can fix the backend?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs all work for me.

Copy link
Member

@rene-dekker rene-dekker Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CI, the patch version is missing from URLs:

https://raw.githubusercontent.com/projectcalico/calico/v3.26/manifests/canal.yaml

It should be v3.26.x. Rather than using {{version}}, you need something that includes the patch.

@bmckercher123 bmckercher123 force-pushed the DOCS-1547-Upgrade-failing branch from 75f25e8 to 0e28223 Compare July 7, 2023 20:10
@bmckercher123 bmckercher123 force-pushed the DOCS-1547-Upgrade-failing branch 2 times, most recently from 95173f3 to cf9a54b Compare August 1, 2023 20:11
@bmckercher123 bmckercher123 removed the request for review from lwr20 August 1, 2023 20:11
@bmckercher123 bmckercher123 force-pushed the DOCS-1547-Upgrade-failing branch 2 times, most recently from cff30d8 to b6b8b01 Compare August 2, 2023 14:47
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bmckercher123 bmckercher123 force-pushed the DOCS-1547-Upgrade-failing branch from b6b8b01 to 0ce8f47 Compare August 2, 2023 17:21
@bmckercher123 bmckercher123 merged commit 4430b37 into tigera:main Aug 2, 2023
@bmckercher123 bmckercher123 deleted the DOCS-1547-Upgrade-failing branch August 2, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants