-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1547-Upgrade-failing #796
DOCS-1547-Upgrade-failing #796
Conversation
✅ Deploy Preview succeeded!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f972161
to
75f25e8
Compare
``` | ||
kubectl replace -f <manifest-file-name> | ||
```bash | ||
kubectl apply --server-side --force-conflicts -f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line and many others the manifest file is no longer present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what your comment means. Are you saying the command should be and leave the reference to manifest?:
kubectl apply -- --force-conflicts -f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be kubectl apply --server-side --force-conflicts -f <manifest-file-name>
@@ -129,16 +129,15 @@ the output and then re-running the command without --dry-run to commit to the ch | |||
|
|||
::: | |||
|
|||
1. Use the following command to initiate a rolling update, after replacing | |||
`<manifest-file-name>` with the file name of your {{version}} manifest. | |||
1. Use the following command to initiate a rolling update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be nicer if the curl step before this step would would store the manifest as a fixed name, like upgrade.yaml
so that you can modify all commands below to apply upgrade.yaml:
kubectl apply --server-side --force-conflicts -f upgrade.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in stead of
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico.yaml -O
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/canal.yaml -O
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico-policy-only.yaml -O
it would be:
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico.yaml -o upgrade.yaml
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/canal.yaml -o upgrade.yaml
curl https://raw.githubusercontent.com/projectcalico/calico/v3.25.1/manifests/calico-policy-only.yaml -o upgrade.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rene-dekker We can do above, but the manifests paths using {{version}} are failing in netlify (see logs). Unless you or Dan can fix the backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These URLs all work for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the CI, the patch version is missing from URLs:
https://raw.githubusercontent.com/projectcalico/calico/v3.26/manifests/canal.yaml
It should be v3.26.x. Rather than using {{version}}
, you need something that includes the patch.
75f25e8
to
0e28223
Compare
95173f3
to
cf9a54b
Compare
cff30d8
to
b6b8b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b6b8b01
to
0ce8f47
Compare
Ticket from community member: #716.
Product Version(s):
OSS 3.25, 3.26
Issue:
https://tigera.atlassian.net/browse/DOCS-1547
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: