Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add DHAVE to ignore list #98

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Nov 21, 2023

PR Type

  • Spellcheck

Related Links

Description

Adds "DHAVE" to the spellcheck exceptions to avoid CI/CD errors (spell-check-differential).

Review Procedure

Check that CI/CD passes.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested review from mojomex and amc-nu November 21, 2023 05:59
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit 71e7d0e into main Nov 21, 2023
7 checks passed
@mojomex mojomex deleted the chore/spellcheck_cmakelists branch November 21, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants