Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nebula_ros): all sensors json schema support #155

Merged
merged 37 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
4f84a5b
ci(nebula): json-schema workflow
amadeuszsz May 24, 2024
dd6f71e
feat(velodyne): add json schema
amadeuszsz May 24, 2024
697e332
feat(robosense): add json schema
amadeuszsz May 24, 2024
07596a4
chore(nebula_ros): remove deprecated config
amadeuszsz May 22, 2024
fe695bb
feat(continental): add radar json schema
amadeuszsz May 23, 2024
cbd52ea
refactor(json-schema): change schema abstraction
amadeuszsz May 30, 2024
39410ab
feat(json-schema): add schema templates
amadeuszsz May 30, 2024
17a40ab
fix(json-schema): remove deprecated script
amadeuszsz May 30, 2024
df8024b
ci(nebula): use latest param-schema action
amadeuszsz May 30, 2024
245398c
feat(json-schema): extend schema template
amadeuszsz May 30, 2024
e7b8bf8
fix(json-schema): calibration default value
amadeuszsz May 31, 2024
8aa8f59
add hesai parameter schema
vividf May 31, 2024
9a7f624
update hesai calibration file
vividf May 31, 2024
0e550f8
move calibration file below the sensor_model
vividf May 31, 2024
6dd3158
remove python file
vividf May 31, 2024
c7eb88e
set default value for pandar yaml
vividf May 31, 2024
a007db6
remove default parameters in nebula_ros
vividf May 31, 2024
98b0f5e
remove default parameter in decoder_wrapper
vividf May 31, 2024
c2d0b31
fix(json-schema): typo
amadeuszsz May 31, 2024
7d93172
fix(json-schema): typo
amadeuszsz May 31, 2024
08912d4
fix(json-schema): typo
amadeuszsz May 31, 2024
50ad41c
fix(json-schema): typo
amadeuszsz May 31, 2024
563d4ad
fix(json-schema): typo
amadeuszsz May 31, 2024
a77b07d
fix(json-schema): typo
amadeuszsz May 31, 2024
cc9c30f
fix(json-schema): typo
amadeuszsz May 31, 2024
f02eb57
fix(json-schema): typo
amadeuszsz May 31, 2024
16a2a49
fix(hesai): remove unused var
amadeuszsz May 31, 2024
446814c
fix(AT128): correct cloud min/max angles
mojomex Jun 1, 2024
8c424ac
fix(ARS548): correct data port default value
mojomex Jun 1, 2024
9ec79d9
add boundary for AT128
vividf Jun 2, 2024
5f5fcaa
docs(json-schema): retry_hw description
amadeuszsz Jun 6, 2024
b28a0fa
docs(json-schema): launch_hw description
amadeuszsz Jun 6, 2024
d52b7b5
fix(json-schema): diag_span minimum
amadeuszsz Jun 6, 2024
6ae941b
fix(json-schema): ptp_profile enum
amadeuszsz Jun 6, 2024
0010eeb
fix(json-schema): ptp_transport_type enum
amadeuszsz Jun 6, 2024
89097f4
fix(json-schema): ptp_profile default value
amadeuszsz Jun 6, 2024
41fa38d
fix(json-schema): ptp_transport_type default value
amadeuszsz Jun 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/json-schema-check.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: json-schema-check

on:
pull_request:
workflow_dispatch:

jobs:
check-if-relevant-files-changed:
runs-on: ubuntu-latest
outputs:
run-check: ${{ steps.paths_filter.outputs.json_or_yaml }}
steps:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: paths_filter
with:
filters: |
json_or_yaml:
- '**/schema/*.schema.json'
- '**/config/**/*.param.yaml'

json-schema-check:
needs: check-if-relevant-files-changed
if: needs.check-if-relevant-files-changed.outputs.run-check == 'true'
runs-on: ubuntu-latest
steps:
- name: Check out repository
uses: actions/checkout@v4

- name: Run json-schema-check
uses: autowarefoundation/autoware-github-actions/json-schema-check@main

no-relevant-changes:
needs: check-if-relevant-files-changed
if: needs.check-if-relevant-files-changed.outputs.run-check == 'false'
runs-on: ubuntu-latest
steps:
- name: Dummy step
run: echo "No relevant changes, passing check"
10 changes: 0 additions & 10 deletions nebula_ros/config/BaseParams.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions nebula_ros/config/hesai/Pandar128E4X.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions nebula_ros/config/hesai/Pandar40P.yaml

This file was deleted.

20 changes: 0 additions & 20 deletions nebula_ros/config/hesai/PandarAT128.yaml

This file was deleted.

18 changes: 0 additions & 18 deletions nebula_ros/config/hesai/PandarQT128.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions nebula_ros/config/hesai/PandarQT64.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions nebula_ros/config/hesai/PandarXT32.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions nebula_ros/config/hesai/PandarXT32M.yaml

This file was deleted.

26 changes: 26 additions & 0 deletions nebula_ros/config/lidar/hesai/Pandar128E4X.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: Pandar128E4X
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 600
return_mode: Dual
ptp_profile: automotive
ptp_domain: 0
ptp_transport_type: L2
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
26 changes: 26 additions & 0 deletions nebula_ros/config/lidar/hesai/Pandar40P.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: Pandar40P
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 600
return_mode: Dual
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
25 changes: 25 additions & 0 deletions nebula_ros/config/lidar/hesai/Pandar64.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: Pandar64
rotation_speed: 600
return_mode: Dual
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
27 changes: 27 additions & 0 deletions nebula_ros/config/lidar/hesai/PandarAT128.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
correction_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).dat
min_range: 0.3
max_range: 300.0
cloud_min_angle: 30
cloud_max_angle: 150
scan_phase: 30.0
sensor_model: PandarAT128
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 200
return_mode: Dual
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
26 changes: 26 additions & 0 deletions nebula_ros/config/lidar/hesai/PandarQT128.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: PandarQT128
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 600
return_mode: LastStrongest
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
26 changes: 26 additions & 0 deletions nebula_ros/config/lidar/hesai/PandarQT64.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: PandarQT64
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 600
return_mode: Dual
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
26 changes: 26 additions & 0 deletions nebula_ros/config/lidar/hesai/PandarXT32.param.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**:
ros__parameters:
host_ip: "255.255.255.255"
sensor_ip: "192.168.1.201"
data_port: 2368
gnss_port: 10110
packet_mtu_size: 1500
launch_hw: true
setup_sensor: true
frame_id: hesai
diag_span: 1000
min_range: 0.3
max_range: 300.0
cloud_min_angle: 0
cloud_max_angle: 360
scan_phase: 0.0
sensor_model: PandarXT32
calibration_file: $(find-pkg-share nebula_decoders)/calibration/hesai/$(var sensor_model).csv
rotation_speed: 600
return_mode: Dual
ptp_profile: "1588v2"
ptp_domain: 0
ptp_transport_type: UDP
ptp_switch_type: TSN
retry_hw: true
dual_return_distance_threshold: 0.1
Loading
Loading