refactor: rename filter parameter name

tier4 · Apr 16, 2024 · 99d5413 · 99d5413
1 parent 0aa148f
commit 99d5413
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/nebula_ros/launch/velodyne_launch_all_hw.xml b/nebula_ros/launch/velodyne_launch_all_hw.xml
@@ -19,7 +19,7 @@
 
     <arg name="setup_sensor" default="True" description="Enable sensor setup on hw-driver."/>
 
-    <arg name="ring_section_filter" default="false"/>
+    <arg name="enable_ring_section_filter" default="false"/>
     <arg name="excluded_ring_sectors"
          default="[0, 3500, 6900], [1, 3400, 6500], [2, 3200, 4600], [3, 3200, 4600]"/>
 
@@ -30,7 +30,7 @@
         <param name="frame_id" value="$(var frame_id)"/>
         <param name="scan_phase" value="$(var scan_phase)"/>
         <param name="calibration_file" value="$(var calibration_file)"/>
-        <param name="ring_section_filter" value="$(var ring_section_filter)"/>
+        <param name="enable_ring_section_filter" value="$(var enable_ring_section_filter)"/>
         <param name="excluded_ring_sectors" type="str" value="$(var excluded_ring_sectors)"/>
     </node>
 

diff --git a/nebula_ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp b/nebula_ros/src/velodyne/velodyne_decoder_ros_wrapper.cpp
@@ -252,9 +252,9 @@ Status VelodyneDriverRosWrapper::GetParameters(
     descriptor.read_only = false;
     descriptor.dynamic_typing = false;
     descriptor.additional_constraints = "";
-    this->declare_parameter<bool>("ring_section_filter", false, descriptor);
+    this->declare_parameter<bool>("enable_ring_section_filter", false, descriptor);
     sensor_configuration.ring_section_filter =
-      this->get_parameter("ring_section_filter").as_bool();
+      this->get_parameter("enable_ring_section_filter").as_bool();
     if (sensor_configuration.ring_section_filter) {
       RCLCPP_DEBUG_STREAM(this->get_logger(), "Ring section filter is active.");
     } else {