Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change launch files to support new nebula architecture #19

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link

@mojomex mojomex commented Jul 18, 2024

PR Type

  • Improvement

Related Links

Description

This PR makes the changes necessary to support the new Nebula single-node architecture.
These changes can be summarized as:

  • merge the separate Nebula nodes into one in the launch file
  • find and read default sensor config file in case none is specified. Parameters specified as arguments will override the values in the file

⚠️ This PR has to be merged in a coordinated manner with the corresponding PRs listed below. The timeline is currently being discussed.

Review Procedure

Compile and run Edge.Auto on a sample rosbag and see if pointclouds are output.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant