Code

Rework filepath (re-)encoding#438

Code

Merged

jennybc merged 17 commits intomaintidyverse/vroom:mainfrom yet-another-filepath-encoding-experimenttidyverse/vroom:yet-another-filepath-encoding-experimentCopy head branch name to clipboardMay 17, 2022

+104-30

Commits

Commits on May 8, 2022

• Revert filepath reencoding

  jennybc

  committed
  76b93e6

  Copy full SHA for 76b93e6

• Unskip this test

  jennybc

  committed
  8e821c0

  Copy full SHA for 8e821c0

• Re-encode to native just prior to fopen() or mio::make_mmap_source()

  jennybc

  committed
  4317c8a

  Copy full SHA for 4317c8a

• Expose the bytes

  jennybc

  committed
  000790d

  Copy full SHA for 000790d

• Unconditionally encode paths as UTF-8

  jennybc

  committed
  bdecf47

  Copy full SHA for bdecf47

Commits on May 9, 2022

• Clean up comments, remove print debugging

  jennybc

  committed
  1023b1c

  Copy full SHA for 1023b1c

Commits on May 11, 2022

• Ensure path returned by chr_to_file() is encoded as UTF-8

  Show description for 2f314b3
  jennybc

  committed
  2f314b3

  Copy full SHA for 2f314b3

• Add more enc2utf8()

  Show description for 5792653
  jennybc

  committed
  5792653

  Copy full SHA for 5792653

• Inline the reference object

  jennybc

  committed
  114c671

  Copy full SHA for 114c671

• Test writing to a non-ascii path

  jennybc

  committed
  8f180e0

  Copy full SHA for 8f180e0

• Test read/write of .zip with non-ascii characters in path

  jennybc

  committed
  004f42c

  Copy full SHA for 004f42c

Commits on May 13, 2022

• Rewrite this test

  jennybc

  committed
  9777c2e

  Copy full SHA for 9777c2e

Commits on May 15, 2022

• I now think the problem IS in archive, for Windows and unix

  Show description for a9436d4
  jennybc

  committed
  a9436d4

  Copy full SHA for a9436d4

Commits on May 17, 2022

• Add a test re: reading fwf from non-ascii filepath

  jennybc

  committed
  4be132c

  Copy full SHA for 4be132c

• Tweaks NEWS

  jennybc

  committed
  e4a6321

  Copy full SHA for e4a6321

• Make versions of basename() and normalizePath() that uphold UTF-8 everywhere

  jennybc

  committed
  432b918

  Copy full SHA for 432b918

• Merge branch 'main' into yet-another-filepath-encoding-experiment

  jennybc

  authored
  833e193

  Copy full SHA for 833e193