-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap glue errors, if possible #294
Conversation
Co-authored-by: Davis Vaughan <[email protected]>
#Conflicts: # DESCRIPTION # R/sql.R
#Conflicts: # NEWS.md
tests/testthat/_snaps/transformer.md
Outdated
Error: | ||
! Failed to evaluate glue component {NOTFOUND} | ||
Caused by error in `identity_transformer()`: | ||
! argument "envir" is missing, with no default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be the error we're trying to test.
After staring long and hard at the CI failures, I realized this. I was puzzled why the R version mattered, since we're using rlang::abort()
. But this error is coming from base R.
I think we either have to give |
Yeah, that looks right to me. Not sure how I missed it originally. |
Fixes #229