Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note instability of nest_by() and group_nest/split() #6657

Conversation

DavisVaughan
Copy link
Member

Closes #6639

  • No NEWS bullet (I'm not really sure what it would say)
  • All still experimental
  • The Life cycle section is something rlang does. i.e. ?rlang::int
  • Marked group_split() as internal and removed pkgdown reference index

R/group-nest.R Outdated
@@ -10,6 +10,10 @@ group_nest_impl <- function(.tbl, .key, keep = FALSE){
#'
#' Nest a tibble using a grouping specification
#'
#' @section Life cycle:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' @section Life cycle:
#' @section Lifecycle:

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i copied rlang but yea that's better

@DavisVaughan DavisVaughan force-pushed the feature/nest-by-group-nest-questioning branch from b4f9224 to fe69e9b Compare January 26, 2023 13:59
@DavisVaughan DavisVaughan merged commit b20d848 into tidyverse:main Jan 26, 2023
@DavisVaughan DavisVaughan deleted the feature/nest-by-group-nest-questioning branch January 26, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark nest_by() and group_*() as questioning rather than experimental
2 participants