Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move across() dots deprecation from deprecate_warn() to deprecate_soft() #6621

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Move across() dots deprecation from deprecate_warn() to deprecate_soft() #6621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07792d7
Move dots deprecation from `deprecate_warn()` to `deprecate_soft()`
DavisVaughan Dec 20, 2022
f264b38
NEWS bullet tweak
DavisVaughan Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@
soft-deprecated, because there was no good alternative until now, but itis
discouraged and will be soft-deprecated in the next minor release.

* Passing `...` to `across()` is deprecated because it's ambiguous when those
arguments are evaluated. Now, instead of (e.g.) `across(a:b, mean, na.rm = TRUE)`
you should write `across(a:b, ~ mean(.x, na.rm = TRUE))` (#6073).
* Passing `...` to `across()` is soft-deprecated because it's ambiguous when
those arguments are evaluated. Now, instead of (e.g.)
`across(a:b, mean, na.rm = TRUE)` you should write
`across(a:b, ~ mean(.x, na.rm = TRUE))` (#6073).

* `all_equal()` is deprecated. We've advised against it for some time, and
we explicitly recommend you use `all.equal()`, manually reordering the rows
Expand Down
2 changes: 1 addition & 1 deletion R/across.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ across <- function(.cols,
" " = "# Now",
" " = "across(a:b, \\(x) mean(x, na.rm = TRUE))"
)
lifecycle::deprecate_warn(
lifecycle::deprecate_soft(
when = "1.1.0",
what = "across(...)",
details = details
Expand Down