Code

adapt errors to next rlang#6052

Code

Merged

romainfrancois merged 139 commits intomaintidyverse/dplyr:mainfrom chained-errorstidyverse/dplyr:chained-errorsCopy head branch name to clipboardNov 8, 2021

+2,172-1,602

Commits

Commits on Oct 14, 2021

• Extract mutate_bullets()

  

  lionel-

  authored and

  romainfrancois

  committed
  c86e953

  Copy full SHA for c86e953

• POC: Use chained errors to provide context

  

  lionel-

  authored and

  romainfrancois

  committed
  ebdbdfe

  Copy full SHA for ebdbdfe

• call =

  romainfrancois

  committed
  469ca45

  Copy full SHA for 469ca45

• add_computed_columns() and distinct() using call=

  romainfrancois

  committed
  c1bf2b6

  Copy full SHA for c1bf2b6

• simplify group_by() error from add_computed_columns() as more context is included in the origin error, from mutate().

  romainfrancois

  committed
  00bed29

  Copy full SHA for 00bed29

• incorporate the parent error (perhaps skipping one layer when the bullets have been reworked)

  romainfrancois

  committed
  4ef7c9c

  Copy full SHA for 4ef7c9c

• dplyr:::internal_error are not suitable for parent=

  romainfrancois

  committed
  73d90ad

  Copy full SHA for 73d90ad

• summarise_bullets(

  romainfrancois

  committed
  b813b7d

  Copy full SHA for b813b7d

• Force:

  Show description for 0d57c52
  romainfrancois

  committed
  0d57c52

  Copy full SHA for 0d57c52

• Pretend call = vec_cast_common

  romainfrancois

  committed
  df60a96

  Copy full SHA for df60a96

• alter the call of errors thrown by vctrs so that they don't mention stop_vctrs() as the origin

  romainfrancois

  committed
  a15f3f7

  Copy full SHA for a15f3f7

• document()

  romainfrancois

  committed
  2e691dd

  Copy full SHA for 2e691dd

• remove redundant summarise() bullet

  romainfrancois

  committed
  1edcc62

  Copy full SHA for 1edcc62

• using cnd_signal()

  romainfrancois

  committed
  6a88e0b

  Copy full SHA for 6a88e0b

• Remove redundant filter() bullet

  romainfrancois

  committed
  089c06d

  Copy full SHA for 089c06d

• reword filter() error

  romainfrancois

  committed
  ec8518f

  Copy full SHA for ec8518f

• factor out filter_expand()

  romainfrancois

  committed
  7e26b09

  Copy full SHA for 7e26b09

• factor out filter_eval()

  Show description for 1363bc2
  romainfrancois

  committed
  1363bc2

  Copy full SHA for 1363bc2

• since we use call2() in other places

  romainfrancois

  committed
  609109e

  Copy full SHA for 609109e

• document()

  romainfrancois

  committed
  8238038

  Copy full SHA for 8238038

Commits on Oct 15, 2021

• Apply suggestions from code review

  Show description for 6b744a8
  

  romainfrancois

  and

  lionel-

  authored
  6b744a8

  Copy full SHA for 6b744a8

• use more explicit name for temporary fix_vctrs_call()

  romainfrancois

  committed
  1c2f176

  Copy full SHA for 1c2f176

• "We detected a named input"

  romainfrancois

  committed
  beffc8d

  Copy full SHA for beffc8d

• using call("<...>") instead of call2("<...>")

  romainfrancois

  committed
  c0bb336

  Copy full SHA for c0bb336

• as_label(<quosure>)

  romainfrancois

  committed
  09ee6a7

  Copy full SHA for 09ee6a7

• Apply suggestions from code review

  Show description for fb9ac71
  

  romainfrancois

  and

  lionel-

  authored
  fb9ac71

  Copy full SHA for fb9ac71

• fix_vctrs_call() gains a class= to add to the list of error classes

  romainfrancois

  committed
  039f983

  Copy full SHA for 039f983

• slice() aborts with call=

  romainfrancois

  committed
  8817927

  Copy full SHA for 8817927

• cnd_header() instead of conditionMessage()

  romainfrancois

  committed
  e6cd326

  Copy full SHA for e6cd326

• Another use of fix_vctrs_call()

  romainfrancois

  committed
  931164a

  Copy full SHA for 931164a

• fix_vctrs_call() -> fix_error() as not strictly about vctrs::

  romainfrancois

  committed
  cca0eaa

  Copy full SHA for cca0eaa

• Rebrand slice() errors in slice_*() siblings

  romainfrancois

  committed
  dd4c919

  Copy full SHA for dd4c919

• limit the reach of the withCallingHandlers() in slice().

  Show description for beb4f45
  romainfrancois

  committed
  beb4f45

  Copy full SHA for beb4f45

• fix_call(), wrap_error() from @lionel- with minor change

  romainfrancois

  committed
  8bcdd2c

  Copy full SHA for 8bcdd2c

• try to improve slice() errors but simplify them when called from sample_*() helprs

  romainfrancois

  committed
  a29294d

  Copy full SHA for a29294d

Commits on Oct 18, 2021

• passing glubort(.envir) to abort() helps error ancestry printing.

  romainfrancois

  committed
  0e762a5

  Copy full SHA for 0e762a5

• adapt to .abort = identity

  romainfrancois

  committed
  e887851

  Copy full SHA for e887851

• merge

  romainfrancois

  committed
  bf43f78

  Copy full SHA for bf43f78

• check_pkg() calling abort() directly

  romainfrancois

  committed
  0520379

  Copy full SHA for 0520379

• auto_copy() using abort() directly.

  romainfrancois

  committed
  a36e829

  Copy full SHA for a36e829

• abort(glue())

  romainfrancois

  committed
  f1ddf15

  Copy full SHA for f1ddf15

• - bad(), use abort() explicitely instead

  romainfrancois

  committed
  51bdae0

  Copy full SHA for 51bdae0

• use abort() directly

  romainfrancois

  committed
  0bd3030

  Copy full SHA for 0bd3030

• call("case_when")

  romainfrancois

  committed
  60483ef

  Copy full SHA for 60483ef

• unused functions

  romainfrancois

  committed
  804cb83

  Copy full SHA for 804cb83

• check_type()/check_class() using abort(call=)

  romainfrancois

  committed
  d13b9fe

  Copy full SHA for d13b9fe

• case_when(), na_if(), if_else() using call=

  romainfrancois

  committed
  d191059

  Copy full SHA for d191059

• glubort() losing .abort argument

  romainfrancois

  committed
  c243c45

  Copy full SHA for c243c45

• unused function

  romainfrancois

  committed
  0d1d234

  Copy full SHA for 0d1d234

• use abort() directly

  romainfrancois

  committed
  95f706f

  Copy full SHA for 95f706f

Commits on Oct 19, 2021

• glue() later the dplyr:::filter_incompatible_size error

  romainfrancois

  committed
  2f055f3

  Copy full SHA for 2f055f3

• glue() later errors of class dplyr:::filter_incompatible_type

  romainfrancois

  committed
  df741f3

  Copy full SHA for df741f3

• simpler abort_glue(), i.e. not glue()ing at all

  romainfrancois

  committed
  80128aa

  Copy full SHA for 80128aa

• abort_glue() -> dplyr_internal_error() simplified

  romainfrancois

  committed
  c772c20

  Copy full SHA for c772c20

• local_call_step() deos not need .fn=

  romainfrancois

  committed
  0eca863

  Copy full SHA for 0eca863

• simplified local_call_step(): losing the .dot_data argument

  romainfrancois

  committed
  bd30b60

  Copy full SHA for bd30b60

• redundant information in warning

  romainfrancois

  committed
  585a7c3

  Copy full SHA for 585a7c3

• only pass the condition to the *_bullets() functions, the other things are rerteieved from the error context: local_error_context()

  romainfrancois

  committed
  0c65f0b

  Copy full SHA for 0c65f0b

• + skip_internal_condition()

  romainfrancois

  committed
  7fba4c8

  Copy full SHA for 7fba4c8

• started refactoring some of summarise()

  romainfrancois

  committed
  26d4c8f

  Copy full SHA for 26d4c8f

• computing -> recycling

  romainfrancois

  committed
  5f6d48d

  Copy full SHA for 5f6d48d

Commits on Oct 20, 2021

• error_context does not need to inherit from environment()

  romainfrancois

  committed
  0dfff00

  Copy full SHA for 0dfff00

• unused

  romainfrancois

  committed
  592b8da

  Copy full SHA for 592b8da

• internal stop_mutate_recycle_incompatible_size() gains expected size so that the bullets method does not need to swim back to peek_mask()

  romainfrancois

  committed
  60cdd84

  Copy full SHA for 60cdd84

• use cnd_bullet_header() in filter_expand()

  romainfrancois

  committed
  1472d77

  Copy full SHA for 1472d77

• auto_copy() using call = auto_copy()

  romainfrancois

  committed
  660c77f

  Copy full SHA for 660c77f

• context_peek() using abort(call=)

  romainfrancois

  committed
  7f35d94

  Copy full SHA for 7f35d94

• filter.ts() using about(call = filter)

  romainfrancois

  committed
  745b97f

  Copy full SHA for 745b97f

• check_compatible() reporting about the caller

  romainfrancois

  committed
  3e0bed9

  Copy full SHA for 3e0bed9

• call = do

  romainfrancois

  committed
  e9113a1

  Copy full SHA for e9113a1

• abort(call = recode)

  romainfrancois

  committed
  c43b1a9

  Copy full SHA for c43b1a9

• Error in desc

  romainfrancois

  committed
  1f92228

  Copy full SHA for 1f92228

• call = recode

  romainfrancois

  committed
  18b5f57

  Copy full SHA for 18b5f57

• lead() also fixing vec_cast_common() call.

  romainfrancois

  committed
  83f7410

  Copy full SHA for 83f7410

• call = ungroup

  romainfrancois

  committed
  0b0c1ab

  Copy full SHA for 0b0c1ab

• More curating the errors

  romainfrancois

  committed
  af85c18

  Copy full SHA for af85c18

Commits on Oct 21, 2021

• - redundant distinct()

  romainfrancois

  committed
  32cafe2

  Copy full SHA for 32cafe2

• fix the call for rows_*()

  romainfrancois

  committed
  c561798

  Copy full SHA for c561798

• group_by_prepare(), using call = group_by

  romainfrancois

  committed
  32cb7d4

  Copy full SHA for 32cb7d4

• change mechanism used in slice() to report differently errors from slice_min(), ...

  romainfrancois

  committed
  6dcfc93

  Copy full SHA for 6dcfc93

• set call= in across_setup() aborts

  romainfrancois

  committed
  d61a7f5

  Copy full SHA for d61a7f5

• call = across + parent when expanding or evaluating across() in summarise() and mutate()

  romainfrancois

  committed
  ff4bef7

  Copy full SHA for ff4bef7

• abort(bullets)

  romainfrancois

  committed
  a0b21cd

  Copy full SHA for a0b21cd

Commits on Oct 22, 2021

• Apply suggestions from code review

  Show description for 12ecf36
  

  romainfrancois

  and

  lionel-

  authored
  12ecf36

  Copy full SHA for 12ecf36

• resnap after review

  romainfrancois

  committed
  13acbb0

  Copy full SHA for 13acbb0

• wrapped_error class is not used

  romainfrancois

  committed
  3c04456

  Copy full SHA for 3c04456

• Update R/recode.R

  Show description for 45facbd
  

  romainfrancois

  and

  lionel-

  authored
  45facbd

  Copy full SHA for 45facbd

• use rlang::arg_require()

  romainfrancois

  committed
  e89912f

  Copy full SHA for e89912f

• across() taking ownership of eval_select() and vec_as_names() errors.

  romainfrancois

  committed
  c41f36d

  Copy full SHA for c41f36d

• + column

  romainfrancois

  committed
  28b346c

  Copy full SHA for 28b346c

• bind_rows() and bind_cols() owning vec_rbind()/vec_cbind() errors

  romainfrancois

  committed
  22c9133

  Copy full SHA for 22c9133

• coalesce() owning errors

  romainfrancois

  committed
  ebdf720

  Copy full SHA for ebdf720

• check_dots_empty(call = )

  romainfrancois

  committed
  5aa77f5

  Copy full SHA for 5aa77f5

• don't show parent of wrapped error

  romainfrancois

  committed
  e3b24c0

  Copy full SHA for e3b24c0

• fix_call(call = ) is explicit now, as these error are always owned by caller, higher level function.

  romainfrancois

  committed
  e709bce

  Copy full SHA for e709bce

• simplify

  romainfrancois

  committed
  d887cad

  Copy full SHA for d887cad

• Remove the unused error class "dplyr_error"

  romainfrancois

  committed
  0d2eab5

  Copy full SHA for 0d2eab5

• slice_sample_error class no longer used

  romainfrancois

  committed
  d81ae18

  Copy full SHA for d81ae18

Commits on Oct 25, 2021

• rlang now reporting the generic instead of the method

  romainfrancois

  committed
  b751f08

  Copy full SHA for b751f08

• fix_call() default should be caller_env()

  romainfrancois

  committed
  b591313

  Copy full SHA for b591313

• fix_call() retrieves the call if given an environment

  romainfrancois

  committed
  e21ed7d

  Copy full SHA for e21ed7d

• using fix_call() default

  romainfrancois

  committed
  2f38747

  Copy full SHA for 2f38747

• fix fix_call() when used from methods.

  romainfrancois

  committed
  ab10631

  Copy full SHA for ab10631

• filter() passing down call environment rather than making a call("filter") down the line.

  romainfrancois

  committed
  61e9b4d

  Copy full SHA for 61e9b4d

• no need to make call("select")

  romainfrancois

  committed
  538d60f

  Copy full SHA for 538d60f

• using local_error_call()

  romainfrancois

  committed
  c4639d6

  Copy full SHA for c4639d6

• mutate_cols(error_call=)

  romainfrancois

  committed
  98b18b6

  Copy full SHA for 98b18b6

• slice_internal(error_call =

  romainfrancois

  committed
  dc69df5

  Copy full SHA for dc69df5

Commits on Oct 26, 2021

• case_when()

  romainfrancois

  committed
  ceba512

  Copy full SHA for ceba512

• rows_*

  romainfrancois

  committed
  a3b291e

  Copy full SHA for a3b291e

• is_compatible_data_frame() making bullets

  romainfrancois

  committed
  2806404

  Copy full SHA for 2806404

• group_map() and friends

  romainfrancois

  committed
  afbc99f

  Copy full SHA for afbc99f

• implicit call

  romainfrancois

  committed
  e8ed14d

  Copy full SHA for e8ed14d

• should -> must, automatic call

  romainfrancois

  committed
  9935682

  Copy full SHA for 9935682

• common_by() automatic call

  romainfrancois

  committed
  78e2fc1

  Copy full SHA for 78e2fc1

• group_by() automatic error_call

  romainfrancois

  committed
  140ed30

  Copy full SHA for 140ed30

• summarise_cols() not taking ..., but taking error_call =

  romainfrancois

  committed
  52131a5

  Copy full SHA for 52131a5

• nest_by() automatic call

  romainfrancois

  committed
  214e42b

  Copy full SHA for 214e42b

• recode() automatic call

  romainfrancois

  committed
  ed44855

  Copy full SHA for ed44855

• add_computed_columns() using error_call rather than add-hoc mechanism

  romainfrancois

  committed
  d46dc32

  Copy full SHA for d46dc32

• arrange() call

  romainfrancois

  committed
  9d2e41a

  Copy full SHA for 9d2e41a

• sample_* call=

  romainfrancois

  committed
  c8598cc

  Copy full SHA for c8598cc

• More error_call

  romainfrancois

  committed
  e627bd0

  Copy full SHA for e627bd0

• DataMask$new(error_call=)

  romainfrancois

  committed
  52fc5dc

  Copy full SHA for 52fc5dc

• document()

  romainfrancois

  committed
  573dbce

  Copy full SHA for 573dbce

• filter_expand(mask=)

  romainfrancois

  committed
  ce52c0c

  Copy full SHA for ce52c0c

• remove snapshot using utf8

  romainfrancois

  committed
  097cab2

  Copy full SHA for 097cab2

Commits on Oct 28, 2021

• Merge branch 'main' into chained-errors

  romainfrancois

  authored
  ce7f5d9

  Copy full SHA for ce7f5d9

• simplicy slice() by using a slice_impl() called by slice.data.frame() and e.g. slice_min.data.frame() instead of javing slice_min.data.frame() call slice()

  romainfrancois

  committed
  dde6cd8

  Copy full SHA for dde6cd8

• also use slice_bullets() for parity

  romainfrancois

  committed
  986a38f

  Copy full SHA for 986a38f

• remove some unused functions

  romainfrancois

  committed
  123311b

  Copy full SHA for 123311b

• slice_bullets.default

  romainfrancois

  committed
  5cd2b16

  Copy full SHA for 5cd2b16

• "must" form

  romainfrancois

  committed
  5882c89

  Copy full SHA for 5882c89

• Capitalize

  romainfrancois

  committed
  ff9c167

  Copy full SHA for ff9c167

• simplify errors from new_grouped_df()

  romainfrancois

  committed
  2b9b68c

  Copy full SHA for 2b9b68c

• must form

  romainfrancois

  committed
  b30e832

  Copy full SHA for b30e832

• must form and wrap error from validate_grouped_df()

  romainfrancois

  committed
  bbe4771

  Copy full SHA for bbe4771

• simpler

  romainfrancois

  committed
  3d1c614

  Copy full SHA for 3d1c614

Commits on Nov 8, 2021

• explicit abort(call =) instead of local_error_call()

  romainfrancois

  committed
  9ac37b7

  Copy full SHA for 9ac37b7