Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in mask methods carry wrong calls #6308

Closed
lionel- opened this issue Jun 26, 2022 · 0 comments · Fixed by #6343
Closed

Errors in mask methods carry wrong calls #6308

lionel- opened this issue Jun 26, 2022 · 0 comments · Fixed by #6343
Labels
bug an unexpected problem or unintended behavior verbs 🏃‍♀️

Comments

@lionel-
Copy link
Member

lionel- commented Jun 26, 2022

CRAN rlang doesn't display calls of the form foo$fn(). Dev rlang now does, which reveals a few call problems in the error snapshots, for instance:

tibble() %>% summarise(stop("{"))
#> Error in `summarise()`:
#> ! Problem while computing `..1 = stop("{")`.
#> Caused by error in `mask$eval_all_summarise()`:
#> ! {
tbl <- tibble(x = 1:2, y = 1:2)
tbl %>%
  group_by(x) %>%
  mutate(y = NULL, a = sum(y))
#> Error in `mutate()`:
#> ! Problem while computing `a = sum(y)`.
#> ℹ The error occurred in group 1: x = 1.
#> Caused by error in `mask$eval_all_mutate()`:
#> ! object 'y' not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior verbs 🏃‍♀️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants