Use length() for simplicity and clarity

tidyverse · Nov 29, 2022 · d9287d1 · d9287d1
1 parent 44abd0a
commit d9287d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/rename.R b/R/rename.R
@@ -75,9 +75,9 @@ rename_with.data.frame <- function(.data, .fn, .cols = everything(), ...) {
       "{.arg .fn} must return a character vector, not {.obj_type_friendly {new}}."
     )
   }
-  if (vec_size(new) != vec_size(sel)) {
+  if (length(new) != length(sel)) {
     cli::cli_abort(
-      "{.arg .fn} must return a vector of size {vec_size(sel)}, not {vec_size(new)}."
+      "{.arg .fn} must return a vector of length {length(sel)}, not {length(new)}."
     )
   }
 

diff --git a/tests/testthat/_snaps/rename.md b/tests/testthat/_snaps/rename.md
@@ -12,7 +12,7 @@
       rename_with(df, fn)
     Condition
       Error in `rename_with()`:
-      ! `.fn` must return a vector of size 2, not 3.
+      ! `.fn` must return a vector of length 2, not 3.
 
 # can't rename in `.cols`