Skip to content

Commit

Permalink
Move across() dots deprecation from deprecate_warn() to `deprecat…
Browse files Browse the repository at this point in the history
…e_soft()` (#6621)

* Move dots deprecation from `deprecate_warn()` to `deprecate_soft()`

* NEWS bullet tweak
  • Loading branch information
DavisVaughan authored Dec 20, 2022
1 parent a21a6e6 commit c4440d8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@
soft-deprecated, because there was no good alternative until now, but itis
discouraged and will be soft-deprecated in the next minor release.

* Passing `...` to `across()` is deprecated because it's ambiguous when those
arguments are evaluated. Now, instead of (e.g.) `across(a:b, mean, na.rm = TRUE)`
you should write `across(a:b, ~ mean(.x, na.rm = TRUE))` (#6073).
* Passing `...` to `across()` is soft-deprecated because it's ambiguous when
those arguments are evaluated. Now, instead of (e.g.)
`across(a:b, mean, na.rm = TRUE)` you should write
`across(a:b, ~ mean(.x, na.rm = TRUE))` (#6073).

* `all_equal()` is deprecated. We've advised against it for some time, and
we explicitly recommend you use `all.equal()`, manually reordering the rows
Expand Down
2 changes: 1 addition & 1 deletion R/across.R
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ across <- function(.cols,
" " = "# Now",
" " = "across(a:b, \\(x) mean(x, na.rm = TRUE))"
)
lifecycle::deprecate_warn(
lifecycle::deprecate_soft(
when = "1.1.0",
what = "across(...)",
details = details
Expand Down

0 comments on commit c4440d8

Please sign in to comment.