Make predict() work with sparse data
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
commented
Sep 24, 2024
tests/testthat/test-sparsevctrs.R
Outdated
| @@ -120,3 +120,51 @@ test_that("sparse matrices can be passed to `fit() - xy", { | |||
| # We expect 1 materialization - the outcome | |||
| expect_snapshot(wf_fit <- fit(wf_spec, hotel_data)) | |||
| }) | |||
|
|
|||
| test_that("sparse tibble can be passed to `predict()", { | |||
There was a problem hiding this comment.
only doing 1 test since it should be able to predict regardless of how the workflow was created
4 tasks
simonpcouch
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Right on.🎸
Ran these tests locally and saw failures due to using CRAN recipes rather than dev--could we add a Remotes here?
Also, as of now, these tests are not run on CI because glmnet isn't installed. I'm 50-50 on whether we ought to, and support you adding a glmnet suggests if you think that's the right move to test these well.
Co-authored-by: Simon P. Couch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #239
This PR:
predict()(same convention as with everything else)