-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test that sparse matrices work with fit()
#258
Conversation
# We expect 1 materialization - the outcome | ||
expect_snapshot(wf_fit <- fit(wf_spec, hotel_data)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can't avoid materialization completely. Because the outcome is sparse. So instead we throw a message when materialization happens. And we just manually have to check that it only shows up once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is embedded in the snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Co-authored-by: Simon P. Couch <[email protected]>
Co-authored-by: Simon P. Couch <[email protected]>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
ref: #239
early in
fit.workflow()
, turn data into sparse tibble if data is sparse matrix.