Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that sparse matrices work with fit() #258

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Conversation

EmilHvitfeldt
Copy link
Member

ref: #239

early in fit.workflow(), turn data into sparse tibble if data is sparse matrix.

Comment on lines +81 to +82
# We expect 1 materialization - the outcome
expect_snapshot(wf_fit <- fit(wf_spec, hotel_data))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can't avoid materialization completely. Because the outcome is sparse. So instead we throw a message when materialization happens. And we just manually have to check that it only shows up once

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is embedded in the snapshot

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

tests/testthat/test-sparsevctrs.R Outdated Show resolved Hide resolved
tests/testthat/test-sparsevctrs.R Outdated Show resolved Hide resolved
tests/testthat/test-sparsevctrs.R Outdated Show resolved Hide resolved
@EmilHvitfeldt EmilHvitfeldt merged commit 602f37e into main Sep 24, 2024
11 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the fit-sparse-matrix branch September 24, 2024 18:08
Copy link

github-actions bot commented Oct 9, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants