Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add brier score to default classification metrics #859

Merged
merged 2 commits into from
Feb 28, 2024
Merged

add brier score to default classification metrics #859

merged 2 commits into from
Feb 28, 2024

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 27, 2024

There causes some extratests breakages but those are pretty easy to change.

@topepo topepo marked this pull request as ready for review February 27, 2024 20:27
@topepo topepo requested a review from EmilHvitfeldt February 27, 2024 20:28
@topepo topepo mentioned this pull request Feb 27, 2024
Merged
@topepo
Copy link
Member Author

topepo commented Feb 27, 2024

I did not see any revdep failures besides the existing ones.

@topepo topepo requested a review from simonpcouch February 27, 2024 20:49
topepo
topepo commented Feb 27, 2024
View reviewed changes
revdep/problems.md
```

# tidyclust
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilHvitfeldt

simonpcouch
simonpcouch reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see that this looks pretty straightforward so far!

Many of the tests in tune use the example generated objects in test/testthat/data. Could we rerun inst/test_objects.R and see how tests look after that?

@simonpcouch simonpcouch mentioned this pull request Feb 28, 2024
Merged
@topepo
Copy link
Member Author

topepo commented Feb 28, 2024

@simonpcouch CI is good and no additional revdep issues

simonpcouch
simonpcouch approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for rerunning those. Let's do it!🙂

Not related to this PR specifically, but noting that we now have a circular dependency with tune and finetune. (tune needs a test change for finetune, finetune needs dev tune features.)

@topepo topepo merged commit 31e3f64 into main Feb 28, 2024
9 checks passed
@topepo topepo deleted the add-brier branch February 28, 2024 22:23
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

@EmilHvitfeldt EmilHvitfeldt Awaiting requested review from EmilHvitfeldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topepo @simonpcouch