Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize message when eval_time is not needed #847

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Feb 14, 2024

closes #811

I went for the concise version of

"{.arg eval_time} is only used for <SITUATION>."

More snapshot changes in tidymodels/extratests#199

Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments; I made a suggestion but don't feel too strongly about it.

R/metric-selection.R Show resolved Hide resolved
R/metric-selection.R Show resolved Hide resolved
@hfrick hfrick merged commit bc3a8b5 into main Feb 20, 2024
9 checks passed
@hfrick hfrick deleted the harmonize-eval_time-not-needed branch February 20, 2024 15:38
simonpcouch added a commit to tidymodels/extratests that referenced this pull request Feb 28, 2024
Copy link

github-actions bot commented Mar 6, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize message text about eval_time being ignored
2 participants