Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align .config entries in tune_bayes() output #718

Merged
merged 5 commits into from
Sep 8, 2023
Merged

align .config entries in tune_bayes() output #718

merged 5 commits into from
Sep 8, 2023

Conversation

simonpcouch
Copy link
Contributor

Closes #715.

tmp_res[[".extracts"]],
~ dplyr::mutate(., .config = paste0("Iter", i))
)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substance of the PR is here and in the untouched lines above; we just need to make the same mutate() happen in .extracts that happened already for .metrics and .predictions.

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking sharp!

@simonpcouch simonpcouch merged commit 74854a5 into main Sep 8, 2023
9 checks passed
@simonpcouch simonpcouch deleted the fix-715 branch September 8, 2023 21:18
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracting with tune_bayes() results in the same .config entry for each iteration
2 participants