Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overly strict test #380

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Remove overly strict test #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a426d
Remove overly strict test
DavisVaughan Nov 29, 2022
c16e169
NEWS bullet
DavisVaughan Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# rsample (development version)

* Removed an overly strict test in preparation for dplyr 1.1.0 (#380).

* All grouped resampling functions (`group_vfold_cv()`, `group_mc_cv()`, `group_initial_split()` and `group_validation_split()`, and `group_bootstraps()`) now support stratification. Strata must be constant within each group (#317, #360, #363, #364, #365).

* `group_bootstraps()` now warns if resampling returns any empty assessment sets (previously had been an error) (#356) (#357).
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-compat-dplyr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ test_that("slice() drops rset class when rows are modified", {

test_that("slice() keeps rset class when rows are untouched", {
for (x in rset_subclasses) {
expect_s3_class_rset(slice(x))
expect_s3_class_rset(slice(x, seq_len(nrow(x))))
}
})
Expand Down