Merge branch 'main' into spark-1045

tidymodels · Jan 17, 2024 · f27f0bb · f27f0bb
2 parents cb66545 + 2752453
commit f27f0bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,8 @@
 
 * Fixed bug in fitting some model types with the `"spark"` engine (#1045).
 
+* Fixed issue in `mlp()` metadata where the `stop_iter` engine argument had been mistakenly protected for the `"brulee"` engine. (#1050)
+
 * `.filter_eval_time()` was moved to the survival standalone file. 
 
 * Improved errors and documentation related to special terms in formulas. See `?model_formula` to learn more. (#770, #1014)

diff --git a/R/mlp_data.R b/R/mlp_data.R
@@ -433,16 +433,6 @@ set_model_arg(
   has_submodel = FALSE
 )
 
-
-set_model_arg(
-  model = "mlp",
-  eng = "brulee",
-  parsnip = "stop_iter",
-  original = "stop_iter",
-  func = list(pkg = "dials", fun = "stop_iter"),
-  has_submodel = FALSE
-)
-
 set_model_arg(
   model = "mlp",
   eng = "brulee",