improve metric checking in show_best.tune_race() (#98)

tidymodels · Jan 18, 2024 · 5714286 · 5714286
1 parent b31a748
commit 5714286
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -19,7 +19,7 @@ URL: https://github.com/tidymodels/finetune,
 BugReports: https://github.com/tidymodels/finetune/issues
 Depends: 
     R (>= 3.5),
-    tune (>= 1.1.2.9004)
+    tune (>= 1.1.2.9011)
 Imports: 
     cli,
     dials (>= 0.1.0),

diff --git a/R/racing_helpers.R b/R/racing_helpers.R
@@ -705,10 +705,10 @@ collect_metrics.tune_race <- function(x, summarize = TRUE, all_configs = FALSE,
 #' different resamples is likely to lead to inappropriate results.
 #' @export
 show_best.tune_race <- function(x, metric = NULL, n = 5, eval_time = NULL, ...) {
-
   if (!is.null(metric)) {
     # What was used to judge the race and how are they being sorted now?
     metrics <- tune::.get_tune_metrics(x)
+    tune::check_metric_in_tune_results(tibble::as_tibble(metrics), metric)
     opt_metric <- tune::first_metric(metrics)
     opt_metric_name <- opt_metric$metric
     if (metric[1] != opt_metric_name) {