Additional check functions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
commented
Oct 20, 2024
topepo
commented
Oct 20, 2024
topepo
commented
Oct 20, 2024
topepo
commented
Oct 20, 2024
| ) | ||
| } | ||
|
|
||
| # check_logical <- function(x, |
There was a problem hiding this comment.
brulee has its own check_logical(). The is temporary to avoid bringing in a lot of snapshots into this PR.
topepo
commented
Oct 20, 2024
tests/testthat/test-checkers.R
Outdated
| expect_silent(brulee:::check_number_whole_vec(variable)) | ||
| expect_silent(brulee:::check_number_whole_vec(variable[1])) | ||
|
|
||
| variable <- seq(0, 1, length.out = 3) |
There was a problem hiding this comment.
This one demonstrates that you can get a whole number returned that is not an integer data type.
added 2 commits
October 20, 2024 15:03
simonpcouch
reviewed
Oct 21, 2024
hfrick
reviewed
Oct 21, 2024
tests/testthat/test-checkers.R
Outdated
There was a problem hiding this comment.
Could you rename either this file or the corresponding R file so that they have the same slug? I.e. either checks or checkers but not both.
|
Oh, we reviewed both! 👀 |
|
But at least we didn't contradict each other 😂 |
Co-authored-by: Simon P. Couch <[email protected]>
EmilHvitfeldt
approved these changes
Oct 21, 2024
|
Worth noting, that a |
Co-authored-by: Emil Hvitfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rlang type checkers lack a few functions. This PR has three: one for a single vector and two to check numeric vectors.