Updates for brulee_mlp_two_layer (#84)

* new function for two layer models * two layer unit tests * avoid overflow issues * fix doc error * test when loss cannot be computed * tests for tunable values * update GHA * update spelling * use current CRAN torch * add missing snapshot and remove print snapshots (due to OS differences) * don't test on R 4.1 * test overflow on M1 mac * small update * finalize tunable for 2layer networks * finalize tunable for 2layer networks * remove tunable info (moved to parsnip) * remove test file --------- Co-authored-by: ‘topepo’ <‘[email protected]’>
tidymodels · Sep 9, 2024 · 478a52c · 478a52c
1 parent 0f90be5
commit 478a52c
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 162 deletions.
diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml
@@ -10,6 +10,8 @@ name: test-coverage.yaml
 
 permissions: read-all
 
+permissions: read-all
+
 jobs:
   test-coverage:
     runs-on: ubuntu-latest

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -40,4 +40,4 @@ Config/testthat/edition: 3
 Encoding: UTF-8
 Language: en-US
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
diff --git a/NAMESPACE b/NAMESPACE
@@ -41,11 +41,6 @@ S3method(print,brulee_linear_reg)
 S3method(print,brulee_logistic_reg)
 S3method(print,brulee_mlp)
 S3method(print,brulee_multinomial_reg)
-S3method(tunable,brulee_linear_reg)
-S3method(tunable,brulee_logistic_reg)
-S3method(tunable,brulee_mlp)
-S3method(tunable,brulee_mlp_two_layer)
-S3method(tunable,brulee_multinomial_reg)
 export("%>%")
 export(autoplot)
 export(brulee_activations)

diff --git a/R/tunable.R b/R/tunable.R
diff --git a/man/brulee-internal.Rd b/man/brulee-internal.Rd
diff --git a/tests/testthat/_snaps/tunable.md b/tests/testthat/_snaps/tunable.md
@@ -336,7 +336,7 @@
       [1] "dials"
       
       [[3]]$fun
-      [1] "hidden_units"
+      [1] "hidden_units_2"
       
       [[3]]$range
       [1]  2 50
@@ -358,7 +358,7 @@
       [1] "dials"
       
       [[5]]$fun
-      [1] "activation"
+      [1] "activation_2"
       
       [[5]]$values
       [1] "relu"        "tanh"        "elu"         "log_sigmoid" "tanhshrink" 

diff --git a/tests/testthat/test-tunable.R b/tests/testthat/test-tunable.R