Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve error reporting when passing wrong values to event listeners #1345

Merged
merged 2 commits into from
Oct 26, 2022
Merged

chore: improve error reporting when passing wrong values to event listeners #1345

merged 2 commits into from
Oct 26, 2022

Conversation

hansemannn
Copy link
Contributor

No description provided.

@hansemannn hansemannn mentioned this pull request Oct 26, 2022
Closed
@hansemannn
Copy link
Contributor Author

Can someone review this? @cb1kenobi @m1ga @ewanharris

cb1kenobi
cb1kenobi approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cb1kenobi cb1kenobi merged commit f88ae87 into master Oct 26, 2022
@hansemannn hansemannn deleted the fix/error-reporting branch October 26, 2022 22:02
@hansemannn
Copy link
Contributor Author

Thanks a lot! Anything I need to do regarding version bump / deployment to get this out in the wild? :)

@cb1kenobi
Copy link
Contributor

@hansemannn I think we need to manually bump the version in the package.json, then create a new release in GitHub: https://github.com/tidev/alloy/releases/new. We can create the tag and GH should autofill the release notes based on the commits.

@cb1kenobi
Copy link
Contributor

@hansemannn is the next release a minor or patch release?

@hansemannn
Copy link
Contributor Author

A patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansemannn @cb1kenobi