Daisy-chaining PatchSet fails to create branch #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashedesimone
requested changes
Mar 10, 2023
ndhaller
commented
Mar 10, 2023
ashedesimone
approved these changes
Mar 14, 2023
Currently, two PatchSet can be chained together to create a dynamic branch. If a third or more PatchSet is chained in a row, these PatchSet fail to create a dynamic branch when used, and non-gracefully fails when the PatchSet steps are attempted on the wrong branch or commit. Locate the correct base PatchSet from the manifest before attempting to create the branch. If a PatchSet circular dependency is found, raise an exception. Do not attempt to create the branch if any exception besides KeyError is encountered. Signed-off-by: Nathaniel Haller <[email protected]> Reviewed-by: Kevin Sun <[email protected]> Reviewed-by: Ashley E Desimone <[email protected]> Reviewed-by: Nate Desimone <[email protected]>
ashedesimone
force-pushed
the
daisy_chain
branch
from
1bdbf00 to
c19bc35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, two PatchSet can be chained together to create a dynamic branch.
If a third or more PatchSet is chained in a row, these PatchSet fail to create a dynamic branch when used, and non-gracefully fails when the PatchSet steps are attempted on the wrong branch or commit.
Locate the correct base PatchSet from the manifest before attempting to create the branch. If a PatchSet circular dependency is found, raise an exception. Do not attempt to create the branch if any exception besides KeyError is encountered.
Signed-off-by: Nathaniel Haller [email protected]