Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): throw error when cannot find @angular/core for ngcc util script #981

Merged
merged 1 commit into from
Aug 11, 2021
Merged

fix(utils): throw error when cannot find @angular/core for ngcc util script #981

merged 1 commit into from
Aug 11, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Aug 11, 2021

Summary

Add an extra check on the existence of @angular/core package to ngcc-jest-processor util script and throw error when @angular/core is not found. This will help users to know if ngcc is invoked correctly or not.

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

N.A.

Other information

@ahnpnl ahnpnl marked this pull request as ready for review August 11, 2021 16:20
@ahnpnl ahnpnl merged commit c35d3f2 into thymikee:master Aug 11, 2021
@ahnpnl ahnpnl deleted the fix-ngcc-utils branch August 11, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant