fix: support all node versions >= 12.13.0 #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtho
approved these changes
May 16, 2021
| @@ -107,6 +107,6 @@ | |||
| ] | |||
| }, | |||
| "engines": { | |||
| "node": "^12.14.1 || ^14.15.0" | |||
| "node": "^12.13.0 || ^14.15.0 || >=15.0.0" | |||
There was a problem hiding this comment.
Just out of curiosity - why lower the 12.x version here?
There was a problem hiding this comment.
copy from https://github.com/facebook/jest/blob/master/package.json#L147 . Angular requires minimum 12.14.1 starting from v12 while v9, v10, v11 doesn't require minimum 12.14.1, kind of hard to combine between Jest and Angular Node version support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #920
Test plan
Added node 15 and node 16 to CI
Does this PR introduce a breaking change?
Other information
N.A.