feat: extend version support range to Angular 18 #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Do you think you could release the change? It would allow us at Nx to support the new version before the Angular release this week. Given that this PR doesn't change any functionality, the change could be released before the Angular version is released. |
|
just did 👍 |
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Angular 18 should be released sometime this week (the Week of November 20th, 2024). This PR allows users to install
jest-preset-angularwithout gettingpeerDependencyerrors, which cause some package managers to fail the installation process.Test plan
We've tested
jest-preset-angular+ Angular 18 as part of the Angular 18 support for Nx, and everything works other than a peer dependency error.Additionally, I created a separate PR with a new example test application using the latest RC version of Angular 18: #2463. The CI checks are all passing. I'll update that PR when the stable version of Angular 18 is released.
Does this PR introduce a breaking change?
Other information