Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: remove __ngContext__ from snapshots #1815

Closed
jepetko opened this issue Nov 2, 2022 · 3 comments · Fixed by #1816
Closed

[Feature]: remove __ngContext__ from snapshots #1815

jepetko opened this issue Nov 2, 2022 · 3 comments · Fixed by #1816

Comments

@jepetko
Copy link
Contributor

jepetko commented Nov 2, 2022

🚀 Feature Proposal

The reasons why should this removed when serializing the fixtures are:

mentioned already in #336

Motivation

Make the tests independent from the internal component implementation.

Example

No change for the clients regarding the usage. A onetime update of snapshots is necessary (removal of ngContext).

jepetko added a commit to jepetko/jest-preset-angular that referenced this issue Nov 2, 2022
jepetko added a commit to jepetko/jest-preset-angular that referenced this issue Nov 2, 2022
jepetko added a commit to jepetko/jest-preset-angular that referenced this issue Nov 4, 2022
jepetko added a commit to jepetko/jest-preset-angular that referenced this issue Nov 4, 2022
@ahnpnl ahnpnl closed this as completed Nov 7, 2022
@guaycuru
Copy link

Has this been released yet? I'm still seeing ngContext in snapshots in v12.2.5

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 25, 2023

No it hasn’t been released yet, I will try to do it soon. Thanks for reminding.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 26, 2023

should be included in 12.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants