Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit hook for prettier + eslint #32

Closed
wants to merge 3 commits into from
Closed

chore: add pre-commit hook for prettier + eslint #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ae3c5
chore: add pre-commit hook for prettier + eslint
with-heart Mar 5, 2021
cb1bd40
chore: use compatible range for husky and lint-staged
with-heart Mar 5, 2021
fe8417d
chore(lint): move eslintcache to node_modules cache
with-heart Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,18 @@
"eslint-plugin-jsx-a11y": "^6.4.1",
"eslint-plugin-prettier": "^3.3.1",
"eslint-plugin-react": "^7.22.0",
"husky": "^4.3.8",
"lint-staged": "^10.5.4",
"prettier": "^2.2.1",
"typescript": "^4.2.3"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged"
}
},
"lint-staged": {
"*.{js,jsx,ts,tsx,md,mdx,yml,json}": "prettier --write",
Copy link
Member

@nihaals nihaals Mar 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml isn't included here. Is this intentional (and trying to set a standard of using yml)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I'll add yaml. Was just following the pattern that the only yaml files in the project currently are yml but they're both totally fine.

"*.{js,jsx,ts,tsx}": "eslint --cache --cache-location node_modules/.cache/.eslintcache --fix"
}
}
Loading