Use pre-commit to enforce code style practices #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown uses double trailing spaces as a line break. Pre-commit will want to remove these. Remove the lines manually. This will make the elements be rendered next to each other in the Storybook, but figuring out how to keep the trailing whitespace in this one file doesn't seem worith it.
Config was changed so that: - trailing new lines are not required in svg files - prettier doesn't mess with indentation in yaml files - prettier doesn't mess with line lengths in yaml files
MythicManiac
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier PR other options were discussed, but this approach was decided on, since it's already in use in other Thunderstore repos.
Closes #32