Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TfA release and beta OAuth ids for gmail #8600

Merged

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 21, 2024

Exchange the Gmail OAuth client ids for release and beta to the ones from the TfA project.

Beta needs a workaround as the package id is still claimed.

NOTE: Only merge once TfA project approved

@wmontwe wmontwe marked this pull request as ready for review November 21, 2024 17:14
@wmontwe wmontwe requested a review from cketti as a code owner November 21, 2024 17:14
@wmontwe wmontwe changed the title Change TBA release and beta OAuth ids for gmail Change TfA release and beta OAuth ids for gmail Nov 25, 2024
@kewisch kewisch marked this pull request as draft November 27, 2024 12:19
@wmontwe
Copy link
Member Author

wmontwe commented Jan 24, 2025

Blocked until the TfA project was approved.

@wmontwe
Copy link
Member Author

wmontwe commented Feb 20, 2025

The project is approved

@wmontwe wmontwe marked this pull request as ready for review February 20, 2025 14:31
@wmontwe wmontwe requested a review from kewisch as a code owner February 20, 2025 14:31
@kewisch
Copy link
Member

kewisch commented Feb 28, 2025

@wmontwe It sounds like we might want to uplift this for the release last minute?

@wmontwe wmontwe added the task: uplift to release Uplift to the release branch label Mar 3, 2025
@wmontwe wmontwe force-pushed the change-tba-release-beta-oauth-ids-for-gmail branch from ecff2b9 to f6de767 Compare March 3, 2025 12:24
@wmontwe wmontwe force-pushed the change-tba-release-beta-oauth-ids-for-gmail branch from f6de767 to 02a17ab Compare March 3, 2025 12:35
@wmontwe
Copy link
Member Author

wmontwe commented Mar 3, 2025

It sounds like we might want to uplift this for the release last minute?

I'll prepare an uplift request.

@wmontwe
Copy link
Member Author

wmontwe commented Mar 3, 2025

@coreycb

[Approval Request Comment]
Original Issue/Pull request: #8600
Regression caused by (issue #): Google required CASA 2 review, see #8829.
User impact if declined: New users will continue to register against the desktop oauth project instead of the Android one.
Testing completed (on daily, etc.): The affected beta and release apps have been tested.
Risk to taking this patch (and alternatives if risky): We need to monitor the OAuth token limit in the Android OAuth project and increase the limit when it goes above 50% utilization.

@wmontwe wmontwe merged commit 49109ad into thunderbird:main Mar 3, 2025
3 checks passed
@wmontwe wmontwe deleted the change-tba-release-beta-oauth-ids-for-gmail branch March 3, 2025 13:10
coreycb pushed a commit to coreycb/thunderbird-android that referenced this pull request Mar 3, 2025
…eta-oauth-ids-for-gmail

Change TfA release and beta OAuth ids for gmail
@coreycb
Copy link
Collaborator

coreycb commented Mar 3, 2025

[Approval Request Comment]
Approved for release

github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
…ds-for-gmail

Change TfA release and beta OAuth ids for gmail
@github-actions github-actions bot removed the task: uplift to release Uplift to the release branch label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants