Remove app #8441
Remove app #8441
Conversation
| VERSION_CODE: ${{ steps.pkginfo.outputs.VERSION_CODE }} | ||
| APPLICATION_ID: ${{ steps.pkginfo.outputs.APPLICATION_ID }} | ||
| app_sha: ${{ steps.shanotes.outputs.app_sha }} | ||
| app_github_notes: ${{ steps.shanotes.outputs.app_github_notes }} |
There was a problem hiding this comment.
Let's use a consistent format with outputs
There was a problem hiding this comment.
Also, if you are using a Matrix job, the outputs will overwrite each other, so you only get one random set of variables.
If we need all of these later, it might make sense that instead of picking them from the apk/aab, we generate them from the sources. We have most of this already in the appinfo step early on, we just need to put it into the right outputs.
| @@ -674,29 +657,93 @@ jobs: | |||
|
|
|||
| cat $GITHUB_OUTPUT | |||
|
|
|||
| - name: Rename release assets | |||
There was a problem hiding this comment.
Renaming them was mainly to make sure we have sensible names in the steps such as release assets and artifact names. I don't think we should have a separate artifact to differentiate renamed vs not renamed.
|
|
||
| publish_summary: | ||
| name: Publish Release Play Store |
| publish_release_playstore: | ||
| name: Publish Release Play Store | ||
| needs: [publish_hold, dump_config, release_commit, pkginfo] | ||
| if: ${{ !failure() && !cancelled() }} # Run if previous step is skipped |
There was a problem hiding this comment.
We can skip this whole job if the skipGooglePlay input is set.
|
Split the publish_release job into pkginfo, publish_release_github, and publish_release_playstore jobs in anticipation of adding a publish_ftpmo job which requires different permissions.
This also discontinues the use of
actions/create-github-app-token@v1for publish_github and replaces it withcontents: 'write'permission.There are no associated changes to the environments to go with this change.