Add Empty Spam command #8126
Add Empty Spam command #8126
Conversation
|
Thanks for the pull request! At a first glance it looks good to me 👍 Sorry, for not providing any feedback earlier. You have probably noticed that we're very busy with getting ready for the first release of Thunderbird for Android. We don't want to include new unplanned features before the release. However, we'll get back to this after the initial release of Thunderbird for Android. |
| boolean isSpamLocalOnly = isSpamLocalOnly(account); | ||
| if (isSpamLocalOnly) { | ||
| localFolder.clearAllMessages(); | ||
| } else { | ||
| localFolder.destroyLocalOnlyMessages(); | ||
| localFolder.setFlags(Collections.singleton(Flag.DELETED), true); | ||
| } |
There was a problem hiding this comment.
Unlike with the trash folder, there never is a local-only spam folder. Assume isSpamLocalOnly is false and simplify the if statement, i.e. only keep the code in the else block.
| val title = getString(R.string.dialog_confirm_empty_spam_title) | ||
| val message = getString(R.string.dialog_confirm_empty_spam_message) |
| @@ -738,6 +738,12 @@ class MessageListFragment : | |||
| } | |||
| } | |||
|
|
|||
| private fun onEmptySpam() { | |||
| if (isShowingSpamFolder) { | |||
| showDialog(R.id.dialog_confirm_empty_spam) | |||
There was a problem hiding this comment.
The ID needs to be added to legacy/ui/legacy/src/main/res/values/ids.xml
| @@ -738,6 +738,12 @@ class MessageListFragment : | |||
| } | |||
| } | |||
|
|
|||
| private fun onEmptySpam() { | |||
| if (isShowingSpamFolder) { | |||
There was a problem hiding this comment.
The isShowingSpamFolder property doesn't exist.
There was a problem hiding this comment.
MessagingController already is way too large. Please move your new code to SpamOperations and write it in Kotlin. See DraftOperations for an example.
Closes #5829
Not tested yet, just copy and pasted what I found of the "Empty Trash" command.
Seems
legacy/core/src/test/java/com/fsck/k9/controller/PendingCommandSerializerTest.javacan be left as-is?