Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DevicePreviews to PreviewDevices #7325

Closed
wants to merge 3 commits into from
Closed

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 6, 2023

DevicePreviews have been renamed to PreviewDevices to follow Google's naming convention for @Preview annotations.

This updates Spotless 6.21.0 -> 6.22.0, Detekt 1.23.0 -> 1.23.3, Detekt Compose Rules 0.1.11 -> 0.3.2

…heme for @Preview annotations

This is no validated by the compose detekt plugin.
@wmontwe wmontwe requested a review from cketti November 6, 2023 15:46
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe changed the title Rename DevicePreviews to `PreviewDevices to follow Google naming sc… Rename DevicePreviews to PreviewDevices Nov 6, 2023
@cketti
Copy link
Member

cketti commented Nov 6, 2023

Did you accidentally push Spotless changes to the wrong branch?

@wmontwe
Copy link
Member Author

wmontwe commented Nov 6, 2023

This needs the updated libraries and updating Spotless won't update ktlint, as it's separately versioned.

@wmontwe
Copy link
Member Author

wmontwe commented Nov 6, 2023

Close this in favor of #7326

@wmontwe wmontwe closed this Nov 6, 2023
@wmontwe wmontwe deleted the rename_device_previews branch November 7, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants