Add account edit save settings screen #7272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsumed for simpler test setup
wmontwe
force-pushed
the
add_account_edit_save_settings_screen
branch
from
a8426e8 to
7415955
Compare
Currently, `useCompression` and `isSendClientIdEnabled` are not part of `ServerSettings` in `Account` (and storage, and settings files, etc). We need to fix this eventually. But it's a larger change. For now we convert between the `ServerSettings` variants at the edges.
cketti
approved these changes
Oct 24, 2023
| Scaffold( | ||
| topBar = { | ||
| AccountTopAppBarWithBackButton( | ||
| title = "Edit Server Settings", |
There was a problem hiding this comment.
Hardcoded text. However, right now the validation screen and the saving screen have different looking headers. We should talk about cleaning this up in the design meeting. We might end up removing this string anyway.
Comment on lines
+34
to
+36
| LaunchedEffect(key1 = Unit) { | ||
| dispatch(Event.SaveServerSettings) | ||
| } |
There was a problem hiding this comment.
This will trigger an additional save operation e.g. after a configuration change. We have the same problem in a couple of other places. I'll create an issue for that.
cketti
added a commit
that referenced
this pull request
Oct 25, 2023
Add account edit save settings screen
|
Manually rebased and merged via 4d14362 to preserve the history in this branch/pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finalises the account server settings editing feature. I removed use of Result/Outcome and used exceptions instead.