Add ImageWithBaseline
#7262
Merged
Add ImageWithBaseline
#7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cketti
force-pushed
the
image_with_baseline
branch
from
518f1c1 to
d8a8555
Compare
wmontwe
reviewed
Oct 18, 2023
| object IconsWithBaseline { | ||
| object Filled { | ||
| val warning: ImageWithBaseline by lazy { | ||
| ImageWithBaseline(image = MaterialIcons.Filled.Warning, baseline = 21.dp) |
There was a problem hiding this comment.
Where is baseline = 21.dp derived from? Is it universally usable or bound to a specific context?
There was a problem hiding this comment.
It's the manually derived baseline for the default size of that particular icon. It's the offset for the lower edge of the triangle. The icon itself contains some empty space at the bottom, so we don't want to align to the bottom edge of it.
wmontwe
reviewed
Oct 18, 2023
| val iconScalingFactor = iconSize / warningIcon.image.defaultHeight | ||
| val iconBaseline = warningIcon.baseline * iconScalingFactor | ||
|
|
||
| Icon( |
There was a problem hiding this comment.
This could be an IconWithBaseline that does the calculation internally, based on the requested size.
There was a problem hiding this comment.
Agreed. But to discuss the approach it felt easier to leave everything in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small visual change. But it introduces
ImageWithBaselinethat can be used as a building block when an icon (with it's own baseline) should be aligned to the baseline of some text next to it.The main purpose of this pull request is to get the design of the "image with baseline" concept right.