Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getters to avoid loading all icons into memory at once #7261

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use getters to avoid loading all icons into memory at once #7261

merged 1 commit into from
Oct 18, 2023

Conversation

cketti
Copy link
Member

@cketti cketti commented Oct 17, 2023

I think my mind procrastinated and brought this to my attention instead of solving the problem I was actually working on.

@cketti cketti requested a review from wmontwe October 17, 2023 10:50
wmontwe
wmontwe approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit b35c96e into main Oct 18, 2023
2 checks passed
@cketti cketti deleted the improve_icons_objects branch October 18, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cketti @wmontwe