Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction mode to server settings #7245

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Oct 12, 2023

This adds an InteractionMode to change behaviour between Create and Edit interactions.

This is used to change the top app bar and remove the protocol selection in case it is an edit.

@wmontwe wmontwe requested a review from cketti October 12, 2023 15:04
@wmontwe wmontwe force-pushed the add_server_settings_interaction_mode branch from 742943c to a6c87b1 Compare October 12, 2023 15:06
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wmontwe wmontwe force-pushed the add_server_settings_interaction_mode branch from a6c87b1 to e898296 Compare October 13, 2023 14:38
@wmontwe wmontwe merged commit 7571469 into main Oct 13, 2023
2 checks passed
@wmontwe wmontwe deleted the add_server_settings_interaction_mode branch October 13, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants