Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown workflow to trigger a spotless check #7222

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Oct 6, 2023

This fixes #7216

@wmontwe wmontwe force-pushed the add_markdown_quality_workflow branch from cc0c84d to 7a7ed19 Compare October 6, 2023 09:21
@wmontwe wmontwe requested a review from cketti October 6, 2023 10:05
@cketti
Copy link
Member

cketti commented Oct 6, 2023

Can we prevent this workflow from running when a PR is also triggering the Android workflow (e.g. when a .kt file and an .md file was changed). Otherwise both workflows will check Markdown files.

@wmontwe
Copy link
Member Author

wmontwe commented Oct 6, 2023

Looking at the docs, it's not straight forward. There is an example to including and exclude paths but that will still trigger when there is a match on **.md. There is also a job if condition, but that goes beyond my knowledge. So maybe?

Edit:

From the docs:

Note: The order that you define paths patterns matters:

A matching negative pattern (prefixed with !) after a positive match will exclude the path.
A matching positive pattern after a negative match will include the path again.

@wmontwe
Copy link
Member Author

wmontwe commented Oct 6, 2023

But the quality check could be a standalone workflow, always checking everything, and the android one just assembles and tests the app code base.

Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially checking Markdown files twice is better than not checking them at all 👍

@wmontwe wmontwe merged commit c752a0f into main Oct 6, 2023
3 checks passed
@wmontwe wmontwe deleted the add_markdown_quality_workflow branch October 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create workflow running spotlessCheck when only Markdown files change
2 participants