Combine settings for navigation action after removing a message #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
requested changes
Oct 5, 2023
There was a problem hiding this comment.
I like that the navigation flow logic has been streamlined. While the name PostRemoveNavigation isn't ideal, I can't provide a better one.
Some of the modified classes reached a size that harms readability, and adding more code to them would be counterproductive.
Optional: The migration logic is scattered across various modules and classes, making it easy to overlook a step. This area could definitely improve with some refactoring.
app/core/src/main/java/com/fsck/k9/preferences/GeneralSettingsDescriptions.java
Show resolved
Hide resolved
cketti
force-pushed
the
post_delete_action
branch
from
fe33a4b to
c209252
Compare
After the user deletes or moves a message in the message view screen, the available navigation options are: - Return to message list - Show previous message - Show next message We get rid of the "magic" mode that tries to keep going in the direction in which the user was moving previously.
cketti
force-pushed
the
post_delete_action
branch
from
c209252 to
4d434b2
Compare
wmontwe
approved these changes
Oct 6, 2023
app/core/src/main/java/com/fsck/k9/preferences/GeneralSettingsDescriptions.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the settings "Return to list after delete" and "Show next message after delete" into a single setting "After deleting or moving a message" (suggestions for a better name are welcome).
After the user deletes or moves a message in the message view screen, the available navigation options are:
We get rid of the "magic" mode that tries to keep going in the direction in which the user was moving previously.